tzulitai commented on a change in pull request #42: [FLINK-16390][sdk] Add view
and clear methods to PersistedTable
URL: https://github.com/apache/flink-statefun/pull/42#discussion_r386763593
##########
File path:
statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/state/FlinkTableAccessor.java
##########
@@ -55,4 +57,19 @@ public void remove(K key) {
throw new RuntimeException(e);
}
}
+
+ @Override
+ public Iterable<Map.Entry<K, V>> view() {
Review comment:
Do you intend the returned iterable to be modifiable (i.e. the iterator
supports `remove()`)?
If so, maybe we should just call this `entries()` instead.
We called the method "view" in the `PersistedAppendingBuffer` to emphasize
the fact that the returned iterable is unmodifiable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
