xintongsong commented on a change in pull request #11284: [FLINK-15911][runtime] Make Flink work with NAT. URL: https://github.com/apache/flink/pull/11284#discussion_r386789347
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceBuilder.java ########## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.rpc.akka; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.runtime.akka.AkkaUtils; +import org.apache.flink.runtime.clusterframework.BootstrapTools; +import org.apache.flink.util.NetUtils; +import org.apache.flink.util.Preconditions; + +import akka.actor.ActorSystem; +import com.typesafe.config.Config; +import org.slf4j.Logger; + +import javax.annotation.Nullable; + +import java.net.InetAddress; + +/** + * Builder for {@link AkkaRpcService}. + */ +public class AkkaRpcServiceBuilder { Review comment: I don't get it. - Constructor of `AkkaRpcService` is used in various of test cases. Unless we want to modify them all, I don't think we can make the constructor private. Maybe it makes sense to annotate the constructor as `VisibleForTesting`, because without the test cases it can be package visibility. - If we cannot make constructor of `AkkaRpcService` private anyway, then I would prefer to put `AkkaRpcServiceBuilder` in a separate file. The file `AkkaRpcService.java` is already quite long. No need to further complicate it. - I don't see how `AkkaRpcService#local(remote)RpcServiceBuilder` is more readable compared to `AkkaRpcServiceUtils#local(remote)ServiceBuilder`. - It probably make sense to make the constructor of the builder private, since we already have `AkkaRpcServiceUtils#local(remote)ServiceBuilder`. In that case, I would tend to put the builder inside `AkkaRpcServiceUtils` rather than `AkkaRpcService`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
