wuchong commented on a change in pull request #11236:
[FLINK-16269][FLINK-16108][table-planner-blink] Fix schema of query and sink do
not match when generic or POJO type is requested
URL: https://github.com/apache/flink/pull/11236#discussion_r386915554
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/sinks/TableSinkUtils.scala
##########
@@ -189,13 +190,45 @@ object TableSinkUtils {
queryLogicalType,
withChangeFlag)
if (LogicalTypeChecks.isCompositeType(requestedOutputType.getLogicalType))
{
- DataTypeUtils.expandCompositeTypeToSchema(requestedOutputType)
+ fromDataTypeToTypeInfo(requestedOutputType) match {
+ case pj: PojoTypeInfo[_] => expandPojoTypeToSchema(pj,
queryLogicalType)
+ case _ =>
DataTypeUtils.expandCompositeTypeToSchema(requestedOutputType)
+ }
} else {
// atomic type
TableSchema.builder().field("f0", requestedOutputType).build()
}
}
+ /**
Review comment:
There is not too much code can be shared (4 lines) and the logic is
different: `SinkCodeGenerator` extracts a fields mapping, however,
`TableSinkUtils` just extract the index.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
