godfreyhe opened a new pull request #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84 URL: https://github.com/apache/flink/pull/11297 ## What is the purpose of the change *[Flip-64](https://cwiki.apache.org/confluence/display/FLINK/FLIP-64%3A+Support+for+Temporary+Objects+in+Table+module) has provided `ConnectTableDescriptor#createTemporaryTable` to register TableSource in TableEnvironment. `fromTableSource(TableSource<?>)` should be deprecated. The execution semantics of `void sqlUpdate(String)` method is inconsistent. DDL will be executed immediately while `INSERT INTO` statement will be buffered. `void sqlUpdate(String)` and `insertInto(String, Table)` will buffer SQLs and Tables, but the buffer behavior is unclear. there is no a clear mechanism through TableEnvironment API to control the whole flow. `execute(String)` method and `explain(boolean)` method are buffer-related method. They should be deprecated, new methods will be introduced by [FLINK-16366](https://issues.apache.org/jira/browse/FLINK-16366) and [FLINK-16367](https://issues.apache.org/jira/browse/FLINK-16367)* ## Brief change log - *Deprecate fromTableSource(TableSource<?>), void sqlUpdate(String), insertInto(String, Table), execute(String), explain(boolean)* ## Verifying this change *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
