Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1418#discussion_r46092993
--- Diff: flink-core/src/main/java/org/apache/flink/util/VersionUtils.java
---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import java.io.IOException;
+import java.net.URL;
+import java.util.Properties;
+import java.util.jar.Attributes;
+import java.util.jar.Manifest;
+
+/**
+ * Utility class which provides various methods for accessing version
information.
+ */
+public final class VersionUtils {
+
+ private static final VersionUtils INSTANCE = new VersionUtils();
+
+ /**
+ * Private constructor used to overwrite public one.
+ */
+ private VersionUtils() {}
+
+ /**
+ * Returns the version of Flink.
+ */
+ public static String getFlinkVersion() {
+ // a version can only be provided when running from a Jar.
+ URL manifestUrl =
INSTANCE.getClass().getClassLoader().getResource("META-INF/MANIFEST.MF");
+ if (manifestUrl != null) {
+ try {
+ Attributes attr = new
Manifest(manifestUrl.openStream()).getMainAttributes();
+ return attr.getValue("Implementation-Version");
+ } catch (IOException e) {
+ //
+ }
+ }
+ return null;
+ }
+
+ /**
+ * Returns the commit id of the source from which the flink jar is
built.
+ */
+ public static String getCommitId() {
--- End diff --
Afaik this is a re-implementation of
`EnvironmentInformation.getRevisionInformation()`. Also the "getFlinkVersion"
method is already implemented in Flink.
Can you re-use the method from the EnvironmentInformation for the CLI
frontend and the web interface?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
