StephanEwen edited a comment on issue #10768: [FLINK-15012][checkpoint] Introduce shutdown to CheckpointStorageCoordinatorView to clean up checkpoint directory. URL: https://github.com/apache/flink/pull/10768#issuecomment-594419275 I am not sure whether we should make it the responsibility of the checkpoint storage to understand when checkpoints can be deleted and when not. Meaning, evaluating the combination of JobStatus and CheckpointProperties. I would think that this is responsibility of the checkpoint coordinator, and the storage simply removes directories when told so. Otherwise, each storage would either implement the same logic (duplication) or have leftover data in different scenarios (inconsistency). *Note:* An indicator of that is that the visibility of `CheckpointProperties` needs to be increased now. This shows that some concept that was only intended for coordinator-internal logic now leaks into other parts. Sometimes, increasing visibility is necessary, but it is always a good indicator that now certain responsibilities/concerns are not separated any more as much as the were before.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
