zentol commented on a change in pull request #11123: [FLINK-16014][s3] Force
usage of SAXParserFactory over XMLReaderFactory in aws-java-sdk-s3.
URL: https://github.com/apache/flink/pull/11123#discussion_r387572783
##########
File path: flink-filesystems/flink-s3-fs-base/pom.xml
##########
@@ -231,6 +231,33 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
Review comment:
it would be safer to move this into the presto/hadoop modules; as it stands
you're excluding one dependency (and kicking out a transitive one), with
downstream modules not being aware that this module is bundling anything and
hence also trying to bundle `aws-java-sdk-s3`.
This is the warning you get when building downstream modules:
```
[WARNING] flink-s3-fs-base-1.11-SNAPSHOT.jar, aws-java-sdk-s3-1.11.271.jar
define 29 overlapping classes:
[WARNING] -
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$GetObjectTaggingHandler
[WARNING] -
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$ListPartsHandler
[WARNING] -
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$BucketLocationHandler
[WARNING] -
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$ListVersionsHandler
[WARNING] -
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$ListAllMyBucketsHandler
[WARNING] -
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$ListBucketInventoryConfigurationsHandler
[WARNING] -
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$ListBucketHandler
[WARNING] -
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$AccessControlListHandler
[WARNING] -
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$InitiateMultipartUploadHandler
[WARNING] -
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$GetBucketInventoryConfigurationHandler
[WARNING] - 19 more...
```
As it stands this will require duplicating things; it would've easier if the
S3 filesystems where organized in a hierarchy such that we could use
inheritance for this stuff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
