JingsongLi commented on a change in pull request #11302: [FLINK-16414]fix sql
validation failed when using udaf/udtf which doesn't implement getResultType
URL: https://github.com/apache/flink/pull/11302#discussion_r387588232
##########
File path:
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/functions/FunctionDefinitionUtilTest.java
##########
@@ -129,4 +174,14 @@ public TypeInformation getAccumulatorType() {
return TypeInformation.of(Object.class);
}
}
+
+ /**
+ * Test function.
+ */
+ public static class TestTableAggFunctionWithoutResultType extends
TableAggregateFunction<Long, Long> {
+ @Override
Review comment:
No, reuse makes code strange. Better to distinguish them clearly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
