rmetzger commented on a change in pull request #11309: [FLINK-16378][AZP]
Disable Docker tests when running with JDK11
URL: https://github.com/apache/flink/pull/11309#discussion_r387691701
##########
File path: tools/azure-pipelines/jobs-template.yml
##########
@@ -161,6 +161,6 @@ jobs:
# TODO remove pre-commit tests script by adding the tests to the nightly
script
# - script: FLINK_DIR=build-target
./flink-end-to-end-tests/run-pre-commit-tests.sh
# displayName: Test - precommit
- - script: FLINK_DIR=`pwd`/build-target
flink-end-to-end-tests/run-nightly-tests.sh
+ - script: ${{parameters.environment}} FLINK_DIR=`pwd`/build-target
flink-end-to-end-tests/run-nightly-tests.sh
Review comment:
Why?
What this does is passing the `PROFILE` variable to the script. This is
necessary for deciding whether we are in a jdk11 setting or not. ... I see a
clear relationship to the title of the JIRA I'm working on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
