TisonKun commented on a change in pull request #11313: [FLINK-16373] Make
JobManagerLeaderListener thread safe
URL: https://github.com/apache/flink/pull/11313#discussion_r387817215
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/JobLeaderService.java
##########
@@ -432,8 +432,8 @@ protected void onRegistrationFailure(Throwable failure) {
@Override
protected CompletableFuture<RegistrationResponse>
invokeRegistration(
JobMasterGateway gateway,
- JobMasterId jobMasterId,
- long timeoutMillis) throws Exception {
+ JobMasterId fencingToken,
Review comment:
Most where we will call it `jobMasterId` though. I'm ok with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
