Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1220#issuecomment-160427679
Hi @danielblazevski, I reviewed your updated pull request. There are only
few problems to merge. Maybe after addressing them, we can merge this to master.
First, there are still some codes with style inconsistency. Could you
reformat all changes with your IDE? If you are using IntelliJ IDEA, you can do
reformatting by pressing Cmd+Alt+Shift+L or Ctrl+Alt+Shift+L.
About test case for `QuadTree`, adding a case to test `QuadTree` with
non-supported distance metric would be good. And I think splitting test case is
necessary. Many test run in a test case currently.
Some implementation doesn't seem scalaesque. I suggest more scalaesque
implementation. Could you review my suggestion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
