hequn8128 commented on a change in pull request #11252:
[FLINK-16337][python][table-planner][table-planner-blink] Add support of
vectorized Python UDF in blink planner and old planner
URL: https://github.com/apache/flink/pull/11252#discussion_r388030258
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/PythonUtil.scala
##########
@@ -32,51 +33,85 @@ object PythonUtil {
* @param node the RexNode to check
* @return true if it contains the Python function call in the specified
node.
*/
- def containsPythonCall(node: RexNode): Boolean = node.accept(new
FunctionFinder(true, true))
+ def containsPythonCall(node: RexNode): Boolean =
Review comment:
How about merging the two `containsPythonCall `. I see two options:
- Add a default parameter for `pythonFunctionKind`.
- Add a GENERAL_PANDAS enum type in `PythonFunctionKind`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
