WeiZhong94 commented on a change in pull request #11238: [FLINK-16304][python] Remove python packages bundled in the flink-python jar. URL: https://github.com/apache/flink/pull/11238#discussion_r388291429
########## File path: flink-python/src/main/resources/META-INF/licenses/LICENSE.cloudpickle ########## @@ -1,32 +0,0 @@ -This module was extracted from the `cloud` package, developed by Review comment: @zentol As the `cloudpickle-1.2.2-src.zip` is still bundled to the binary release, its license file need to copy to the binary release. But `collect_license_files.sh` only collects the license files in jar, which means we need to add some code to ensure that the `LICENSE.cloudpickle` can be collected by the script. There are 2 solutions in my mind: 1. bundle the license file to `flink-python.jar` 2. let the `collect_license_files.sh` also collect the license files in the root `license` directory. What do you think about those solutions? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
