AHeise commented on a change in pull request #11195: [FLINK-16222][runtime] Use
plugins mechanism for initializing MetricReporters
URL: https://github.com/apache/flink/pull/11195#discussion_r388312499
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -119,7 +120,7 @@
private boolean shutdown;
- public TaskManagerRunner(Configuration configuration, ResourceID
resourceId) throws Exception {
+ public TaskManagerRunner(Configuration configuration, ResourceID
resourceId, PluginManager pluginManager) throws Exception {
Review comment:
`FileSystem` can also take a null for plugin manager. We should probably
extract an interface and have a no-op implementation instead. That's out of
scope for this PR though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
