zentol edited a comment on issue #11305: [FLINK-16410][e2e][build] Add explicit flink-runtime dependency URL: https://github.com/apache/flink/pull/11305#issuecomment-595277009 > Would every test now need to know about this mechanism and need to manually promote the transitive runtime dependency? No, because we are fixing this at the source. Note that this PR only modifies `flink-end-to-end-tests`, not the module of the failing test `flink-metrics-reporter-prometheus-test`. This is all just due to a combination of using transitive undeclared dependencies + provided scope + dependency reduction. Could we make flink-dist a `compile` dependency? Sure, but it's a) highly unusual for us to do so and b) we don't actually want all transitive dependencies to bleed into downstream modules. Could we ban used undeclared dependencies? Sure, but no one (but me) wants that noise in the pom. Could we selectively disable dependency reduction? Sure, but that introduces additional special cases of which we have more than enough.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
