[ 
https://issues.apache.org/jira/browse/FLINK-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031851#comment-15031851
 ] 

ASF GitHub Bot commented on FLINK-2522:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1412#discussion_r46149535
  
    --- Diff: 
flink-staging/flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkILoop.scala
 ---
    @@ -95,24 +140,49 @@ class FlinkILoop(
         new File(tmpDirBase, "scala_shell_commands.jar")
       }
     
    -  private val packageImports = Seq[String](
    -    "org.apache.flink.core.fs._",
    -    "org.apache.flink.core.fs.local._",
    -    "org.apache.flink.api.common.io._",
    -    "org.apache.flink.api.common.aggregators._",
    -    "org.apache.flink.api.common.accumulators._",
    -    "org.apache.flink.api.common.distributions._",
    -    "org.apache.flink.api.common.operators._",
    -    "org.apache.flink.api.common.operators.base.JoinOperatorBase.JoinHint",
    -    "org.apache.flink.api.common.functions._",
    -    "org.apache.flink.api.java.io._",
    -    "org.apache.flink.api.java.aggregation._",
    -    "org.apache.flink.api.java.functions._",
    -    "org.apache.flink.api.java.operators._",
    -    "org.apache.flink.api.java.sampling._",
    -    "org.apache.flink.api.scala._",
    -    "org.apache.flink.api.scala.utils._"
    -  )
    +  private val packageImports =
    +    streaming match {
    +      case StreamingMode.BATCH_ONLY => Seq[String](
    +      "org.apache.flink.core.fs._",
    +      "org.apache.flink.core.fs.local._",
    +      "org.apache.flink.api.common.io._",
    +      "org.apache.flink.api.common.aggregators._",
    +      "org.apache.flink.api.common.accumulators._",
    +      "org.apache.flink.api.common.distributions._",
    +      "org.apache.flink.api.common.operators._",
    +      
"org.apache.flink.api.common.operators.base.JoinOperatorBase.JoinHint",
    +      "org.apache.flink.api.common.functions._",
    +      "org.apache.flink.api.java.io._",
    +      "org.apache.flink.api.java.aggregation._",
    +      "org.apache.flink.api.java.functions._",
    +      "org.apache.flink.api.java.operators._",
    +      "org.apache.flink.api.java.sampling._",
    +      "org.apache.flink.api.scala._",
    +      "org.apache.flink.api.scala.utils._"
    +    )
    +      case StreamingMode.STREAMING => Seq[String](
    +       "org.apache.flink.core.fs._",
    +      "org.apache.flink.core.fs.local._",
    +      "org.apache.flink.api.common.io._",
    +      "org.apache.flink.api.common.aggregators._",
    +      "org.apache.flink.api.common.accumulators._",
    +      "org.apache.flink.api.common.distributions._",
    +      "org.apache.flink.api.common.operators._",
    +      
"org.apache.flink.api.common.operators.base.JoinOperatorBase.JoinHint",
    +      "org.apache.flink.api.common.functions._",
    +      "org.apache.flink.api.java.io._",
    +      "org.apache.flink.api.java.aggregation._",
    +      "org.apache.flink.api.java.functions._",
    +      "org.apache.flink.api.java.operators._",
    +      "org.apache.flink.api.java.sampling._",
    +      "org.apache.flink.api.scala._",
    +      "org.apache.flink.api.scala.utils._",
    +      "org.apache.flink.streaming._",
    +      "org.apache.flink.streaming.connectors.rabbitmq._",
    --- End diff --
    
    Why this import?


> Integrate Streaming Api into Flink-scala-shell
> ----------------------------------------------
>
>                 Key: FLINK-2522
>                 URL: https://issues.apache.org/jira/browse/FLINK-2522
>             Project: Flink
>          Issue Type: Improvement
>          Components: Scala Shell
>            Reporter: Nikolaas Steenbergen
>            Assignee: Nikolaas Steenbergen
>
> startup scala shell with "-s" or "-streaming" flag to use the streaming api



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to