aljoscha commented on a change in pull request #10526: [FLINK-15090][build] 
Reverse the dependency from flink-streaming-java to flink-client
URL: https://github.com/apache/flink/pull/10526#discussion_r389772193
 
 

 ##########
 File path: flink-clients/src/main/java/org/apache/flink/client/ClientUtils.java
 ##########
 @@ -128,16 +128,23 @@ public static void executeProgram(
 
                        LOG.info("Starting program (detached: {})", 
!configuration.getBoolean(DeploymentOptions.ATTACHED));
 
-                       ContextEnvironmentFactory factory = new 
ContextEnvironmentFactory(
+                       ContextEnvironment benv = new ContextEnvironment(
 
 Review comment:
   This changes the behaviour quite a bit? Before, every call to 
`ExecutionEnvironment.getEnvironment()` would create a new env from the 
factory. Now we only have one environment and keep returning that from the 
anonymous inner factory created in `setAsContext()`. Whats the reason for this 
change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to