zenfenan commented on issue #11307: [FLINK-16371] [BulkWriter] Fix Hadoop 
Compression BulkWriter
URL: https://github.com/apache/flink/pull/11307#issuecomment-596642628
 
 
   @kl0u I have made the changes per your review comments. 
   
   Regarding the Integration test, I just wanted to add that the 
`NotSerializableException` is thrown during StreamingFileSink execution saying 
that the `CompressionCodec` implementation being used is a non serializable 
field. It doesn't say `HadoopCompressionBulkWriter` is non serializable. Is a 
separate IT required?
   
   And for the `SerializableHadoopConfiguration`, I will make a separate patch 
and get rid of this Map based approach. What do you say?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to