wuchong commented on issue #11119: [FLINK-15396][json] Support to ignore parse errors for JSON format URL: https://github.com/apache/flink/pull/11119#issuecomment-596949777 Hi @zoudan , I think the added test is too simple and can't cover the changes. I propose to add some test data and iterate the test data to verify the exception and error suppression. I also tried that in my local branch and find some missing part and some code can be further improved. I also re-thought the exception catch logic, I think we can just catch the exception in `wrapIntoNullableConverter`, all the exception happened in conversion can be regarded as parse errors. That will be much simpler. Regarding to the behavior of `failOnMissingField` and `ignoreParseErrors` are both enabled, I find csv format treat missing field as parse errors too. But it's a little weird the missing field error is not reported when `failOnMissingField` is true. So I would like to propose to disable this case for now, i.e. `failOnMissingField` and `ignoreParseErrors` is unsupported currently. We can revisit this and introduce the behavior in the future. I have a PoC branch for the above things: https://github.com/wuchong/flink/tree/pull/11119 What do you think about that? @zoudan
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
