zhijiangW commented on a change in pull request #11354: [FLINK-14551][task] Unaligned checkpoints: API for persistence URL: https://github.com/apache/flink/pull/11354#discussion_r390167839
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/InputChannelInfo.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.checkpoint.channel; + +import org.apache.flink.annotation.Internal; + +import java.io.Serializable; + +/** + * Identifies {@link org.apache.flink.runtime.io.network.partition.consumer.InputChannel} in a given subtask. + */ +@Internal +public class InputChannelInfo implements Serializable { Review comment: It indeed brings confusing for having both `InputChannelID` and `InputChannelInfo` now. `InputChannelID` is the unique id for identifying while requesting partitions from different tasks on upstream side. `InputChannelInfo` is a wrapper structure which would be easily extended to cover more infos (e.g. task index) future if necessary. And currently the strong requirement is to identify it for different `InputGate` instances. The "inspiration" is form existing `TaskInfo` structure coincides with `executionId`. I also do not see a better solution yet. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
