GJL commented on a change in pull request #11250: [FLINK-16302][rest]add log
list and read log by name for taskmanager
URL: https://github.com/apache/flink/pull/11250#discussion_r390157774
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java
##########
@@ -211,9 +211,18 @@ void notifySlotAvailable(
*
* @param taskManagerId identifying the {@link TaskExecutor} to upload
the specified file
* @param fileType type of the file to upload
+ * @param fileName name of the file to upload
* @param timeout for the asynchronous operation
* @return Future which is completed with the {@link TransientBlobKey}
after uploading the file to the
* {@link BlobServer}.
*/
- CompletableFuture<TransientBlobKey>
requestTaskManagerFileUpload(ResourceID taskManagerId, FileType fileType,
@RpcTimeout Time timeout);
+ CompletableFuture<TransientBlobKey>
requestTaskManagerFileUpload(ResourceID taskManagerId, FileType fileType,
String fileName, @RpcTimeout Time timeout);
Review comment:
Imo a method signature like this is hard to understand and confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
