pnowojski commented on a change in pull request #11347:
[FLINK-14971][checkpointing] Make all the non-IO operations in
CheckpointCoordinator single-threaded
URL: https://github.com/apache/flink/pull/11347#discussion_r390285228
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -588,8 +588,8 @@ private void startTriggeringCheckpoint(
final CompletableFuture<?>
coordinatorCheckpointsComplete = pendingCheckpointCompletableFuture
.thenComposeAsync((pendingCheckpoint) ->
OperatorCoordinatorCheckpoints.triggerAndAcknowledgeAllCoordinatorCheckpointsWithCompletion(
-
coordinatorsToCheckpoint, pendingCheckpoint, timer),
- timer);
+
coordinatorsToCheckpoint, pendingCheckpoint, mainThreadExecutor),
Review comment:
Shouldn't this commit:
> [hotfix] Fix broken DefaultSchedulerTest by satisfying the main thread
requirement of CheckpointCoordinator
be squashed with the preceding one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
