jinglining commented on a change in pull request #11250: [FLINK-16302][rest]add
log list and read log by name for taskmanager
URL: https://github.com/apache/flink/pull/11250#discussion_r390286564
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -900,7 +921,7 @@ public void heartbeatFromResourceManager(ResourceID
resourceID) {
}
@Override
- public CompletableFuture<TransientBlobKey> requestFileUpload(FileType
fileType, Time timeout) {
+ public CompletableFuture<TransientBlobKey> requestFileUpload(FileType
fileType, String fileName, Time timeout) {
Review comment:
Sounds good, also update methods' name may be better.
```java
CompletableFuture<TransientBlobKey> requestFileUploadByName(String fileName,
@RpcTimeout Time timeout);
CompletableFuture<TransientBlobKey> requestFileUploadByType(FileType
fileType, @RpcTimeout Time timeout);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
