gaoyunhaii commented on a change in pull request #7368: [FLINK-10742][network] Let Netty use Flink's buffers directly in credit-based mode URL: https://github.com/apache/flink/pull/7368#discussion_r390471418
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyMessageClientSideSerializationTest.java ########## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.netty; + +import org.apache.flink.core.memory.MemorySegment; +import org.apache.flink.core.memory.MemorySegmentFactory; +import org.apache.flink.runtime.io.network.TestingPartitionRequestClient; +import org.apache.flink.runtime.io.network.buffer.Buffer; +import org.apache.flink.runtime.io.network.buffer.BufferCompressor; +import org.apache.flink.runtime.io.network.buffer.BufferDecompressor; +import org.apache.flink.runtime.io.network.buffer.FreeingBufferRecycler; +import org.apache.flink.runtime.io.network.buffer.NetworkBuffer; +import org.apache.flink.runtime.io.network.buffer.NetworkBufferPool; +import org.apache.flink.runtime.io.network.partition.consumer.InputChannelID; + +import org.apache.flink.runtime.io.network.partition.consumer.RemoteInputChannel; +import org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate; +import org.apache.flink.shaded.netty4.io.netty.buffer.ByteBuf; +import org.apache.flink.shaded.netty4.io.netty.channel.embedded.EmbeddedChannel; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +import java.io.IOException; +import java.util.Arrays; +import java.util.Collection; +import java.util.Random; + +import static org.apache.flink.runtime.io.network.netty.NettyTestUtil.encodeAndDecode; +import static org.apache.flink.runtime.io.network.netty.NettyTestUtil.verifyBufferResponseHeader; +import static org.apache.flink.runtime.io.network.netty.NettyTestUtil.verifyErrorResponse; +import static org.apache.flink.runtime.io.network.partition.InputChannelTestUtils.createRemoteInputChannel; +import static org.apache.flink.runtime.io.network.partition.InputChannelTestUtils.createSingleInputGate; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertTrue; + +/** + * Tests for the serialization and deserialization of the various {@link NettyMessage} sub-classes + * sent from server side to client side. + */ +@RunWith(Parameterized.class) +public class NettyMessageClientSideSerializationTest { + + private static final int BUFFER_SIZE = 1024; + + private static final BufferCompressor COMPRESSOR = new BufferCompressor(BUFFER_SIZE, "LZ4"); + + private static final BufferDecompressor DECOMPRESSOR = new BufferDecompressor(BUFFER_SIZE, "LZ4"); + + private final Random random = new Random(); + + private EmbeddedChannel channel; + + private NetworkBufferPool networkBufferPool; + + private SingleInputGate inputGate; + + private InputChannelID inputChannelId; + + // ------------------------------------------------------------------------ + // parameters + // ------------------------------------------------------------------------ + + private final boolean testReadOnlyBuffer; + + private final boolean testCompressedBuffer; + + @Parameterized.Parameters(name = "testReadOnlyBuffer = {0}, testCompressedBuffer = {1}") + public static Collection<Object[]> testReadOnlyBuffer() { + return Arrays.asList(new Object[][] { + {false, false}, + {true, false}, + {false, true}, + {true, true} + }); + } + + public NettyMessageClientSideSerializationTest(boolean testReadOnlyBuffer, boolean testCompressedBuffer) { + this.testReadOnlyBuffer = testReadOnlyBuffer; + this.testCompressedBuffer = testCompressedBuffer; + } + + @Before + public void setup() throws IOException, InterruptedException { + networkBufferPool = new NetworkBufferPool(8, BUFFER_SIZE, 8); + inputGate = createSingleInputGate(1); + RemoteInputChannel inputChannel = createRemoteInputChannel( + inputGate, + new TestingPartitionRequestClient(), + networkBufferPool); + inputChannel.requestSubpartition(0); + inputGate.assignExclusiveSegments(); + + CreditBasedPartitionRequestClientHandler handler = new CreditBasedPartitionRequestClientHandler(); + handler.addInputChannel(inputChannel); + + channel = new EmbeddedChannel( + new NettyMessage.NettyMessageEncoder(), // For outbound messages + new NettyMessageClientDecoderDelegate(handler)); // For inbound messages + + inputChannelId = inputChannel.getInputChannelId(); + } + + @After + public void tearDown() throws IOException { + inputGate.close(); + + networkBufferPool.destroyAllBufferPools(); + networkBufferPool.destroy(); + + channel.close(); + } + + @Test + public void testBufferResponse() { + NetworkBuffer buffer = new NetworkBuffer(MemorySegmentFactory.allocateUnpooledSegment(BUFFER_SIZE), FreeingBufferRecycler.INSTANCE); + + for (int i = 0; i < BUFFER_SIZE; i += 8) { + buffer.writeLong(i); + } + + Buffer testBuffer = testReadOnlyBuffer ? buffer.readOnlySlice() : buffer; + if (testCompressedBuffer) { + testBuffer = COMPRESSOR.compressToOriginalBuffer(buffer); + } + + NettyMessage.BufferResponse expected = new NettyMessage.BufferResponse( + testBuffer, random.nextInt(), inputChannelId, random.nextInt()); + NettyMessage.BufferResponse actual = encodeAndDecode(expected, channel); + + assertTrue(buffer.isRecycled()); + assertTrue(testBuffer.isRecycled()); + + assertNotNull( + "The request input channel should always have available buffers in this test.", + actual.getBuffer()); + ByteBuf retainedSlice = actual.getBuffer().asByteBuf(); + if (testCompressedBuffer) { + assertTrue(actual.isCompressed); + retainedSlice = decompress(retainedSlice); + } + + // Ensure not recycled and same size as original buffer + assertEquals(1, retainedSlice.refCnt()); + assertEquals(BUFFER_SIZE, retainedSlice.readableBytes()); + + for (int i = 0; i < BUFFER_SIZE; i += 8) { + assertEquals(i, retainedSlice.readLong()); + } + + // Release the received message. + actual.releaseBuffer(); + if (testCompressedBuffer) { + retainedSlice.release(); + } + assertEquals(0, retainedSlice.refCnt()); + + verifyBufferResponseHeader(expected, actual); + } + + @Test + public void testErrorResponseWithoutErrorMessage() { + IllegalStateException expectedError = new IllegalStateException(); + InputChannelID receiverId = new InputChannelID(); + + NettyMessage.ErrorResponse expected = new NettyMessage.ErrorResponse(expectedError, receiverId); + NettyMessage.ErrorResponse actual = encodeAndDecode(expected, channel); + + verifyErrorResponse(expected, actual); + } + + @Test + public void testErrorResponseWithErrorMessage() { + IllegalStateException expectedError = new IllegalStateException("Illegal illegal illegal"); + InputChannelID receiverId = new InputChannelID(); + + NettyMessage.ErrorResponse expected = new NettyMessage.ErrorResponse(expectedError, receiverId); + NettyMessage.ErrorResponse actual = encodeAndDecode(expected, channel); + + verifyErrorResponse(expected, actual); + } + + @Test + public void testErrorResponseWithFatalError() { Review comment: Extractor the common method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
