zhijiangW commented on a change in pull request #7368: [FLINK-10742][network] Let Netty use Flink's buffers directly in credit-based mode URL: https://github.com/apache/flink/pull/7368#discussion_r390781744
########## File path: flink-end-to-end-tests/flink-netty-shuffle-memory-control-test/src/main/java/org/apache/flink/streaming/tests/NettyShuffleMemoryControlTestProgram.java ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.tests; + +import org.apache.flink.api.java.utils.ParameterTool; +import org.apache.flink.configuration.ConfigOption; +import org.apache.flink.configuration.ConfigOptions; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.flink.streaming.api.functions.sink.RichSinkFunction; +import org.apache.flink.streaming.api.functions.source.RichParallelSourceFunction; + +import org.apache.flink.shaded.netty4.io.netty.util.internal.OutOfDirectMemoryError; + +import sun.misc.Unsafe; + +import static org.apache.flink.util.Preconditions.checkArgument; + +/** + * Test program to verify the direct memory consumption of Netty. Without zero-copy Netty + * may create more than one chunk, thus we may encounter {@link OutOfDirectMemoryError} if + * we limit the total direct memory to be less than two chunks. Instead, with zero-copy + * introduced in (https://issues.apache.org/jira/browse/FLINK-10742) one chunk will be + * enough and the exception will not occur. + * + * <p>Since Netty uses low level API of {@link Unsafe} to allocate direct buffer when using + * JDK8 and these memory will not be counted in direct memory, the test is only effective + * when JDK11 is used. + */ +public class NettyShuffleMemoryControlTestProgram { + private static final int RECORD_LENGTH = 2048; + + private static final ConfigOption<Integer> RUNNING_TIME_IN_SECONDS = ConfigOptions + .key("test.running_time_in_seconds") + .defaultValue(120) + .withDescription("The time to run."); + + private static final ConfigOption<Integer> MAP_PARALLELISM = ConfigOptions + .key("test.map_parallelism") + .defaultValue(1) + .withDescription("The number of map tasks."); + + private static final ConfigOption<Integer> REDUCE_PARALLELISM = ConfigOptions + .key("test.reduce_parallelism") + .defaultValue(1) + .withDescription("The number of reduce tasks."); + + public static void main(String[] args) throws Exception { + // parse the parameters + final ParameterTool params = ParameterTool.fromArgs(args); + + final int runningTimeInSeconds = params.getInt(RUNNING_TIME_IN_SECONDS.key(), RUNNING_TIME_IN_SECONDS.defaultValue()); + final int mapParallelism = params.getInt(MAP_PARALLELISM.key(), MAP_PARALLELISM.defaultValue()); + final int reduceParallelism = params.getInt(REDUCE_PARALLELISM.key(), REDUCE_PARALLELISM.defaultValue()); + + checkArgument(runningTimeInSeconds > 0, + "The running time in seconds should be positive, but it is {}", + runningTimeInSeconds); + checkArgument(mapParallelism > 0, + "The number of map tasks should be positive, but it is {}", + mapParallelism); + checkArgument(reduceParallelism > 0, + "The number of reduce tasks should be positve, but it is {}", + reduceParallelism); + + StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); + env.addSource(new StringSourceFunction(runningTimeInSeconds)) + .setParallelism(mapParallelism) + .slotSharingGroup("a") + .shuffle() + .addSink(new DummySink()) + .setParallelism(reduceParallelism) + .slotSharingGroup("b"); + + // execute program + env.execute("TaskManager Direct Memory Test"); Review comment: nit: "TaskManager Direct Memory Test" should also be adjusted with changing the class name ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
