zentol commented on a change in pull request #11238: [FLINK-16304][python]
Remove python packages bundled in the flink-python jar.
URL: https://github.com/apache/flink/pull/11238#discussion_r390967221
##########
File path: tools/releasing/collect_license_files.sh
##########
@@ -57,4 +57,9 @@ LICENSES="${DST}/licenses"
[ -f "${LICENSES}" ] && rm -r "${LICENSES}"
find "${TMP}" -name "licenses" -type d -exec cp -r -- "{}" "${DST}" \;
+# Search the binary distribution directory and collect those license files that
+# not bundled in any jars.
+find "${SRC}/flink-dist/target" -name "LICENSE.*" -type f \
+-path "*/flink-*-bin/*" ! -path "*/licenses/*" -exec cp -- "{}"
"${DST}/licenses" \;
Review comment:
- `-path "*/flink-*-bin/*"` should not be necessary with the above
suggestion.
- It may be worthwhile to explicitly exclude `${TMP}/licenses` and
`${DST}/licenses`; this script should continue to work even if the python
licenses are moved into to `opt/python/licenses`.
- maybe to a move instead so we have a single point for licenses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
