aljoscha commented on a change in pull request #7702:
[FLINK-11088][Security][YARN] Allow YARN to discover pre-installed keytab files
URL: https://github.com/apache/flink/pull/7702#discussion_r391138151
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -359,6 +359,40 @@ public static void addToEnvironment(Map<String, String>
environment,
StringInterner.weakIntern(val));
}
+ /**
+ * Resolve keytab path either as absolute path or relative to working
directory.
+ *
+ * @param workingDir current working directory
+ * @param keytabPath configured keytab path.
+ * @return resolved keytab path, or null if not found.
+ */
+ public static String resolveKeytabPath(String workingDir, String
keytabPath) {
+ String keytab = null;
+ if (keytabPath == null) { // keytab not exist
+ LOG.info("keytab path isn't configured!");
Review comment:
I think we shouldn't log here, because now all users will always get this
log message, even if they don't do anything with Kerberos, that might be
confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
