zhengcanbin commented on issue #11378: [FLINK-16546][yarn] Fix logging bug in YarnClusterDescriptor#startAppMaster URL: https://github.com/apache/flink/pull/11378#issuecomment-597964958 > It is pretty obvious that this error happened because the code has been copy-pasted from above. > Ideally, I would recommend to refactor this into one or more methods, then errors like this would not occur. > > +1 to merge this. Thanks for the review @XuQianJin-Stars, @rmetzger. How about adding a new utility method such as FileUtils#deleteFileOrDirectoryQuietly to delete the file or the directory quietly but log error message once an exception occurs.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
