godfreyhe commented on a change in pull request #11340: [Flink 14338] Upgrade 
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r391453790
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/agg/DistinctAggregateTest.xml
 ##########
 @@ -283,9 +283,122 @@ Calc(select=[EXPR$0, EXPR$1, CAST(EXPR$2) AS EXPR$2])
             +- HashAggregate(isMerge=[true], groupBy=[a, b, d, e, $e, $e_0], 
select=[a, b, d, e, $e, $e_0, Final_COUNT(count$0) AS EXPR$2])
                +- Exchange(distribution=[hash[a, b, d, e, $e, $e_0]])
                   +- LocalHashAggregate(groupBy=[a, b, d, e, $e, $e_0], 
select=[a, b, d, e, $e, $e_0, Partial_COUNT(c) AS count$0])
-                     +- Expand(projects=[{a=[$0], b=[null], c=[$2], d=[$3], 
e=[$4], $e=[$5], $e_0=[8]}, {a=[null], b=[$1], c=[$2], d=[$3], e=[$4], $e=[$5], 
$e_0=[16]}, {a=[null], b=[null], c=[$2], d=[$3], e=[$4], $e=[$5], $e_0=[24]}], 
projects=[{a, null AS b, c, d, e, $e, 8 AS $e_0}, {null AS a, b, c, d, e, $e, 
16 AS $e_0}, {null AS a, null AS b, c, d, e, $e, 24 AS $e_0}])
-                        +- Expand(projects=[{a=[$0], b=[$1], c=[$2], d=[$3], 
e=[null], $e=[1]}, {a=[$0], b=[$1], c=[$2], d=[null], e=[$4], $e=[2]}], 
projects=[{a, b, c, d, null AS e, 1 AS $e}, {a, b, c, null AS d, e, 2 AS $e}])
+                     +- Expand(projects=[a, b, c, d, e, $e, $e_0], 
projects=[{a, null AS b, c, d, e, $e, 8 AS $e_0}, {null AS a, b, c, d, e, $e, 
16 AS $e_0}, {null AS a, null AS b, c, d, e, $e, 24 AS $e_0}])
+                        +- Expand(projects=[a, b, c, d, e, $e], projects=[{a, 
b, c, d, null AS e, 1 AS $e}, {a, b, c, null AS d, e, 2 AS $e}])
                            +- TableSourceScan(table=[[default_catalog, 
default_database, MyTable2, source: [TestTableSource(a, b, c, d, e)]]], 
fields=[a, b, c, d, e])
+]]>
+    </Resource>
+  </TestCase>
+  <TestCase name="testMultiDistinctAndNonDistinctAggWithFilter">
 
 Review comment:
   it's difficult to compare the plans, keep the original tests order ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to