danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade Calcite version to 1.22 for Flink SQL URL: https://github.com/apache/flink/pull/11340#discussion_r391535995
########## File path: flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/agg/AggregateReduceGroupingTest.xml ########## @@ -359,7 +359,7 @@ HashAggregate(isMerge=[true], groupBy=[a3, b3, a1], auxGrouping=[b1], select=[a3 <![CDATA[ LogicalProject(a4=[$0], b4=[$1], EXPR$2=[$3]) +- LogicalAggregate(group=[{0, 1, 2}], EXPR$2=[COUNT($3)]) - +- LogicalProject(a4=[$0], b4=[$1], $f2=[TUMBLE($3, 900000:INTERVAL MINUTE)], c4=[$2]) + +- LogicalProject(a4=[$0], b4=[$1], $f2=[$TUMBLE($3, 900000:INTERVAL MINUTE)], c4=[$2]) Review comment: The `$TUMBLE` is used for the group window syntax `group by tumble ...`, while the `TUMBLE` now is a builtin table value function, see CALCITE-3382 and commit https://github.com/apache/calcite/commit/b80bb1cbceb11ed31b73e419916b5cc98610503e ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services