GJL commented on a change in pull request #11250: [FLINK-16302][rest]add log
list and read log by name for taskmanager
URL: https://github.com/apache/flink/pull/11250#discussion_r391798715
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java
##########
@@ -216,9 +227,18 @@
*/
CompletableFuture<Boolean> canBeReleased();
+
+ /**
+ * Requests for the historical log file names on the TaskManager.
+ *
+ * @return A Tuple2 Array with all log file names with its length.
+ */
+ CompletableFuture<Collection<Tuple2<String, Long>>>
requestLogList(@RpcTimeout Time timeout);
Review comment:
I would prefer not to use `Tuple2<String, Long>`. IMO tuple types should be
used sparingly because its semantics are often not clear. I would prefer to
introduce a new type or just use
`org.apache.flink.runtime.rest.messages.taskmanager.LogInfo`. There are some
downsides with reusing types but it has been done like that before (for
example, see `ResourceManager#requestTaskManagerInfo()`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
