[
https://issues.apache.org/jira/browse/FLINK-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058385#comment-17058385
]
Jark Wu edited comment on FLINK-16441 at 3/13/20, 3:05 AM:
-----------------------------------------------------------
Hi [~gyfora], thanks for the pull request, I reviewed the changes. I think I
had some misunderstanding on this issue before.
I was thinking it is the "SET" command doesn't work to set a Flink
configuration (e.g. parallelism.default).
>From the changes and the issue description, the purpose is in order to make
>the configuration section of {{sql-client-defaults.yaml}} can set Flink
>configurations.
But I guess that should work, because we forward
{{TableConfig#getConfiguration()}} to {{StreamExecutionEnvironment}} [1] before
translate into JobGraph. I verified {{parallelism.default}} and
{{pipeline.object-reuse}} and it works.
Did you spot any Flink configuration that doesn't work by setting in
{{sql-client-defaults.yaml}} ?
[1]:
https://github.com/apache/flink/blob/release-1.10/flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala#L145
was (Author: jark):
I [~gyfora], I reviewed the changes. I think I had some misunderstanding on
this issue.
I was thinking it is the "SET" command doesn't work to set a Flink
configuration (e.g. parallelism.default).
>From the changes and the issue description, the purpose is in order to make
>the configuration section of {{sql-client-defaults.yaml}} can set Flink
>configurations.
But I guess that should work, because we forward
{{TableConfig#getConfiguration()}} to {{StreamExecutionEnvironment}} [1] before
translate into JobGraph. I verified {{parallelism.default}} and
{{pipeline.object-reuse}} and it works.
Did you spot any Flink configuration that doesn't work by setting in
{{sql-client-defaults.yaml}} ?
[1]:
https://github.com/apache/flink/blob/release-1.10/flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala#L145
> Allow users to override flink-conf parameters from SQL CLI environment
> ----------------------------------------------------------------------
>
> Key: FLINK-16441
> URL: https://issues.apache.org/jira/browse/FLINK-16441
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Client
> Reporter: Gyula Fora
> Assignee: Gyula Fora
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.10.1, 1.11.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There is currently no way of overriding flink configuration parameters when
> using the SQL CLI.
> The configuration section of the env yaml should provide a way of doing so as
> this is a very important requirement for multi-user/multi-app flink client
> envs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
