ifndef-SleePy commented on a change in pull request #11347:
[FLINK-14971][checkpointing] Make all the non-IO operations in
CheckpointCoordinator single-threaded
URL: https://github.com/apache/flink/pull/11347#discussion_r392803884
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -403,7 +403,10 @@ public void shutdown(JobStatus jobStatus) throws
Exception {
// clear queued requests and in-flight checkpoints
abortPendingAndQueuedCheckpoints(reason);
- completedCheckpointStore.shutdown(jobStatus);
+ // there might be a race condition with IO threads on
completedCheckpointStore
Review comment:
The race condition happens between `completedCheckpointStore.shutdown` and
`completedCheckpointStore.addCheckpoint`.
> And previously was it working becase CompletedCheckpointStore access were
synchronized on the checkopint coordinator's lock?
Yes, exactly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
