AHeise commented on a change in pull request #11403: [FLINK-16316][operators] 
Implement new StreamOperatorBase as a replacement for AbstractStreamOperator
URL: https://github.com/apache/flink/pull/11403#discussion_r392927611
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorFactory.java
 ##########
 @@ -61,16 +59,16 @@ public void setMailboxExecutor(MailboxExecutor 
mailboxExecutor) {
        }
 
        @Override
-       public StreamOperator createStreamOperator(StreamTask containingTask, 
StreamConfig config, Output output) {
+       public <T extends StreamOperator<OUT>> T 
createStreamOperator(StreamOperatorInitializer<OUT> initializer) {
 
 Review comment:
   @rkhachatryan wanted to get rid of this method's generic afaik. It's really 
a bit anti pattern. So I'm not sure going into it makes any sense. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to