tillrohrmann commented on a change in pull request #11313: [FLINK-16373] Make
JobManagerLeaderListener thread safe
URL: https://github.com/apache/flink/pull/11313#discussion_r393694811
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/JobLeaderService.java
##########
@@ -230,18 +231,20 @@ public void reconnect(final JobID jobId) {
*/
private final class JobManagerLeaderListener implements
LeaderRetrievalListener {
+ private final Object lock = new Object();
+
/** Job id identifying the job to look for a leader. */
private final JobID jobId;
/** Rpc connection to the job leader. */
- private volatile RegisteredRpcConnection<JobMasterId,
JobMasterGateway, JMTMRegistrationSuccess> rpcConnection;
+ private RegisteredRpcConnection<JobMasterId, JobMasterGateway,
JMTMRegistrationSuccess> rpcConnection;
Review comment:
Sounds good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
