kl0u commented on a change in pull request #11322: [FLINK-16376][yarn] Use
consistent method to get Yarn application dir…
URL: https://github.com/apache/flink/pull/11322#discussion_r394154087
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java
##########
@@ -161,10 +161,8 @@ private void testRecursiveUploadForYarn(String scheme,
String pathSuffix) throws
assumeFalse(fs.exists(basePath));
try {
- final Path directory = new Path(basePath, pathSuffix);
-
YarnFileStageTest.testCopyFromLocalRecursive(fs.getHadoopFileSystem(),
- new
org.apache.hadoop.fs.Path(directory.toUri()), Path.CUR_DIR, tempFolder, false);
+ Path.CUR_DIR, tempFolder, false);
Review comment:
@jiasheng55 in general we are trying to avoid using `mockito` in our tests,
so I suggest to try to get rid of it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
