nielsbasjes commented on a change in pull request #11316: [FLINK-16432] Fix 
dependencies in Hive Connector build
URL: https://github.com/apache/flink/pull/11316#discussion_r394206025
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/pom.xml
 ##########
 @@ -40,6 +40,14 @@ under the License.
                <reflections.version>0.9.8</reflections.version>
        </properties>
 
+       <repositories>
+               <repository>
+                       <!-- Needed for 
org.pentaho:pentaho-aggdesigner-algorithm:pom:5.1.5-jhyde -->
+                       <id>spring-lib-release</id>
+                       <url>https://repo.spring.io/libs-release/</url>
 
 Review comment:
   This is dependency,  not a plugin. So this repo url is strange.  
   I'm not sure what the purpose of this library is. I have seen multiple 
projects where this exact dependency has been causing problems. 
   
   If there is a better way to fix this I'll gladly refactor my pull request 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to