azagrebin commented on a change in pull request #11408:
[FLINK-15989][FLINK-16225] Improve direct and metaspace out-of-memory error
handling
URL: https://github.com/apache/flink/pull/11408#discussion_r394208538
##########
File path:
flink-core/src/main/java/org/apache/flink/core/memory/MemorySegmentFactory.java
##########
@@ -94,7 +99,15 @@ public static MemorySegment
allocateUnpooledOffHeapMemory(int size) {
* @return A new memory segment, backed by unpooled off-heap memory.
*/
public static MemorySegment allocateUnpooledOffHeapMemory(int size,
Object owner) {
- ByteBuffer memory = ByteBuffer.allocateDirect(size);
+ ByteBuffer memory;
+ try {
+ memory = ByteBuffer.allocateDirect(size);
+ } catch (OutOfMemoryError e) {
+ if (ExceptionUtils.isDirectOutOfMemoryError(e)) {
+
LOG.error(ExceptionUtils.TM_DIRECT_OOM_ERROR_MESSAGE, e);
+ }
+ throw e;
+ }
Review comment:
I agree, improving the error message of exception should also help here to
report more details to the receiver.
It would be nice to figure out a way to handle direct OOM errors from Netty
threads in general because Netty also can allocate direct memory. Same for
Netty threads in Akka RPC framework. These tasks can be follow-ups.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
