danny0405 commented on a change in pull request #11340: [Flink 14338] Upgrade
Calcite version to 1.22 for Flink SQL
URL: https://github.com/apache/flink/pull/11340#discussion_r394771769
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/WindowAggregateReduceFunctionsRule.scala
##########
@@ -39,14 +40,26 @@ import scala.collection.JavaConversions._
class WindowAggregateReduceFunctionsRule
extends AggregateReduceFunctionsRule(
operand(classOf[LogicalWindowAggregate], any()),
- RelFactories.LOGICAL_BUILDER) {
+ RelBuilder.proto(
+ Contexts.of(
+ RelFactories.DEFAULT_STRUCT,
+ RelBuilder.Config.DEFAULT
+ .withPruneInputOfAggregate(false)))) {
override def newAggregateRel(
relBuilder: RelBuilder,
oldAgg: Aggregate,
newCalls: util.List[AggregateCall]): Unit = {
// create a LogicalAggregate with simpler aggregation functions
+
+ // Because of:
+ // [CALCITE-3763] RelBuilder.aggregate should prune unused fields from the
input,
+ // if the input is a Project.
+ //
+ // the field can not be pruned if it is referenced by other expressions
+ // of the window aggregation(i.e. the TUMBLE_START/END).
+ // To solve this, we config the RelBuilder to forbidden this feature.
Review comment:
The comment makes the change more clear, so i choose to keep them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
