wangyang0918 commented on a change in pull request #11323: [FLINK-16439][k8s]
Make KubernetesResourceManager starts workers using WorkerResourceSpec
requested by SlotManager
URL: https://github.com/apache/flink/pull/11323#discussion_r394773325
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManager.java
##########
@@ -278,7 +288,7 @@ private void removePodIfTerminated(KubernetesPod pod) {
kubeClient.stopPod(pod.getName());
final KubernetesWorkerNode kubernetesWorkerNode =
workerNodes.remove(new ResourceID(pod.getName()));
if (kubernetesWorkerNode != null) {
- requestKubernetesPodIfRequired();
+
requestKubernetesPodIfRequired(podWorkerResources.get(pod.getName()));
Review comment:
We might get a null `WorkerResourceSpec` here after failover. Then we will
try to call `requestKubernetesPodIfRequired(null)`.
Also no pod will be allocated, since we do not how to allocate a new same
one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
