rmetzger commented on a change in pull request #11430: [FLINK-16633][AZP] Fix 
builds without s3 credentials
URL: https://github.com/apache/flink/pull/11430#discussion_r395196045
 
 

 ##########
 File path: azure-pipelines.yml
 ##########
 @@ -40,13 +40,19 @@ resources:
   - container: flink-build-container
     image: rmetzger/flink-ci:ubuntu-amd64-3528acd
 
-# See tools/azure-pipelines/jobs-template.yml for a short summary of the 
caching
+# Define variables:
+# - See tools/azure-pipelines/jobs-template.yml for a short summary of the 
caching
+# - See 
https://stackoverflow.com/questions/60742105/how-can-i-access-a-secret-value-from-an-azure-pipelines-expression
 
 Review comment:
   Currently on master, we have the `$(variables.IT_CASE_S3_BUCKET)` syntax, 
which, returns the variable, or `$(variables.IT_CASE_S3_BUCKET)` if nothing is 
set.
   What I first proposed in the PR was `$[variables.IT_CASE_S3_BUCKET]`, which 
is always empty, if you use it in the `env` block of a task.
   Now, I use this weird workaround of defining the variables in the pipeline 
definion.
   
   I don't think this behavior is very intuitive.
   
   
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to