[
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041428#comment-15041428
]
ASF GitHub Bot commented on FLINK-2111:
---------------------------------------
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-161939523
Have you added the tests for the REST interface? I couldn't find them. For
the future it might be helpful, if you simply push commits to your PR branch
without squashing them. It is impossible for me to see what you've actually
changed with your last commit.
Concerning the REST test case, I assume that you have to start a
`JobManager` with the `WebRuntimeMonitor` running. Then you submit a job and
send a stop request to the web interface. I would assume that you can use any
HTTP client for that. Afterwards you can check the JSON result and verify that
the job has actually been stopped. That you can also directly do by querying
the `JobManager`.
It would be important to also add such a test for the yarn use case. There
you can take a look at the existing yarn test cases to see how to start yarn
cluster. It's important because Yarn only allows GET requests, if I'm not
mistaken.
> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
> Key: FLINK-2111
> URL: https://issues.apache.org/jira/browse/FLINK-2111
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime, JobManager, Local Runtime,
> Streaming, TaskManager, Webfrontend
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks
> such that the sources can stop emitting data and shutdown cleanly, resulting
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for
> https://issues.apache.org/jira/browse/FLINK-1929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
