xintongsong commented on a change in pull request #11284:
[FLINK-15911][runtime] Make Flink work with NAT.
URL: https://github.com/apache/flink/pull/11284#discussion_r395428193
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
##########
@@ -54,6 +54,16 @@
" leader-election service (like ZooKeeper) is used to
elect and discover the JobManager" +
" leader from potentially multiple standby
JobManagers.");
+ /**
+ * The local address of the network interface that the job manager
binds to.
+ */
+ public static final ConfigOption<String> BIND_HOST =
+ key("jobmanager.bind-host")
Review comment:
This address is not only used by the RPC service, but also shared by the
blob server, rest server, and potentially any other service in future that
needs to bind to the network interface.
To that end, I think the config option for TM ("taskmanager.host") makes
more sense. I guess that might be the reason we use "host" in the config key at
the first place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
