tillrohrmann commented on a change in pull request #11284:
[FLINK-15911][runtime] Make Flink work with NAT.
URL: https://github.com/apache/flink/pull/11284#discussion_r395534217
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterConfiguration.java
##########
@@ -102,21 +102,21 @@ public int getNumTaskManagers() {
public String getJobManagerBindAddress() {
return commonBindAddress != null ?
commonBindAddress :
-
configuration.getString(JobManagerOptions.ADDRESS, "localhost");
+
configuration.getString(JobManagerOptions.BIND_HOST, "localhost");
}
public String getTaskManagerBindAddress() {
return commonBindAddress != null ?
commonBindAddress :
-
configuration.getString(TaskManagerOptions.HOST, "localhost");
+
configuration.getString(TaskManagerOptions.BIND_HOST, "localhost");
}
- public String getJobManagerBindPortRange() {
- return
String.valueOf(configuration.getInteger(JobManagerOptions.PORT, 0));
+ public int getJobManagerBindPort() {
+ return
configuration.getInteger(JobManagerOptions.RPC_BIND_PORT, 0);
}
- public String getTaskManagerBindPortRange() {
- return configuration.getString(TaskManagerOptions.RPC_PORT);
+ public int getTaskManagerBindPort() {
+ return
configuration.getInteger(TaskManagerOptions.RPC_BIND_PORT, 0);
Review comment:
I think the problem I see is that we are using `RPC_BIND_PORT` and
`BIND_HOST` as the external address and port when creating the `RpcService` in
the `MiniCluster`. It might not be a big problem but it is a behaviour
inconsistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
