zhengcanbin commented on a change in pull request #10973:
[FLINK-15647][kubernetes] Support to set annotations for JM/TM Pods.
URL: https://github.com/apache/flink/pull/10973#discussion_r395540341
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -129,6 +129,10 @@
.defaultValue("/opt/flink/log")
.withDescription("The directory that logs of jobmanager and
taskmanager be saved in the pod.");
+ public static final String KUBERNETES_JOBMANAGER_ANNOTATION_PREFIX =
"kubernetes.jobmanager.annotation.";
Review comment:
I also notice that
[FLINK-15640](https://issues.apache.org/jira/browse/FLINK-15640) plans to use
the map config option. It could confuse the users that we use map type for
labels/node-selectors and use string type for annotations.
@tillrohrmann @TisonKun Do we have guides on whether we should use the map
type for a config option that is exposed to the users?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
