[ 
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043990#comment-15043990
 ] 

ASF GitHub Bot commented on FLINK-2488:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1386#discussion_r46773630
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/broadcast/BroadcastVariableMaterialization.java
 ---
    @@ -178,9 +178,9 @@ private boolean decrementReferenceInternal(BatchTask<?, 
?> referenceHolder, bool
                                if (errorIfNoReference) {
                                        throw new IllegalStateException(
                                                        String.format("The task 
%s (%d/%d) did not hold a reference to the broadcast variable %s.",
    -                                                                   
referenceHolder.getEnvironment().getTaskName(),
    -                                                                   
referenceHolder.getEnvironment().getIndexInSubtaskGroup() + 1,
    -                                                                   
referenceHolder.getEnvironment().getNumberOfSubtasks(),
    +                                                                   
referenceHolder.getEnvironment().getTaskInfo().getTaskName(),
    --- End diff --
    
    Can replace this with `getTaskInfo().getTaskNameWithSubtasks()`.


> Expose attemptNumber in RuntimeContext
> --------------------------------------
>
>                 Key: FLINK-2488
>                 URL: https://issues.apache.org/jira/browse/FLINK-2488
>             Project: Flink
>          Issue Type: Improvement
>          Components: JobManager, TaskManager
>    Affects Versions: 0.10.0
>            Reporter: Robert Metzger
>            Assignee: Sachin Goel
>            Priority: Minor
>
> It would be nice to expose the attemptNumber of a task in the 
> {{RuntimeContext}}. 
> This would allow user code to behave differently in restart scenarios.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to