tillrohrmann commented on a change in pull request #10973: [FLINK-15647][k8s] 
Support user-specified annotations for JM/TM Pods
URL: https://github.com/apache/flink/pull/10973#discussion_r396336277
 
 

 ##########
 File path: 
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java
 ##########
 @@ -63,6 +65,12 @@ public KubernetesJobManagerParameters(Configuration 
flinkConfig, ClusterSpecific
                return 
getPrefixedEnvironments(ResourceManagerOptions.CONTAINERIZED_MASTER_ENV_PREFIX);
        }
 
+       @Nullable
 
 Review comment:
   This should either go to the interface `KubernetesParameters` or preferrably 
we return an empty map if it has not been set.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to