[ 
https://issues.apache.org/jira/browse/FLINK-16742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrey Zagrebin updated FLINK-16742:
------------------------------------
    Description: 
Currently, the legacy options `_jobmanager.heap.size_` (or 
`_jobmanager.heap.mb_`) is used in JM standalone bash scripts to pass JVM heap 
size arg and start JM JVM process.

BashJavaUtils should be extended to get JVM memory arg list string from Flink 
configuration. BashJavaUtils can use 
JobManagerProcessUtils#processSpecFromConfig to obtain JobManagerProcessSpec. 
JobManagerProcessSpec can be passed to 
ProcessMemoryUtils#generateJvmParametersStr to get JVM memory arg list string.

The configuration should be fixed to fallback to 
JobManagerOptions.JVM_HEAP_MEMORY if a legacy option is set 
(JobManagerProcessUtils#getConfigurationWithLegacyHeapSizeMappedToNewConfigOption)
 before passing it to JobManagerProcessUtils#processSpecFromConfig.

Then the VM memory arg list from BashJavaUtils can be used in JM standalone 
bash scripts instead the existing bash code which parses legacy heap options: 
`_jobmanager.heap.size_` (or `_jobmanager.heap.mb_`).

  was:
Currently, the legacy options `_jobmanager.heap.size_` (or 
`_jobmanager.heap.mb_`) is used in JM standalone bash scripts to pass JVM heap 
size arg and start JM JVM process.

BashJavaUtils should be extended to get JVM memory arg list string from Flink 
configuration. BashJavaUtils can use 
JobManagerProcessUtils#processSpecFromConfig to obtain JobManagerProcessSpec. 
JobManagerProcessSpec can be passed to 
ProcessMemoryUtils#generateJvmParametersStr to get JVM memory arg list string.

The configuration should be fixed to fallback to new options if legacy options 
are set 
(JobManagerProcessUtils#getConfigurationWithLegacyHeapSizeMappedToNewConfigOption)
 before passing it to JobManagerProcessUtils#processSpecFromConfig.

Then the VM memory arg list from BashJavaUtils can be used in JM standalone 
bash scripts instead the existing bash code which parses legacy heap options: 
`_jobmanager.heap.size_` (or `_jobmanager.heap.mb_`).


> Extend and use BashJavaUtils to start JM JVM process and pass JVM memory args
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-16742
>                 URL: https://issues.apache.org/jira/browse/FLINK-16742
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Deployment / Scripts, Runtime / Configuration, Runtime / 
> Coordination
>            Reporter: Andrey Zagrebin
>            Priority: Major
>
> Currently, the legacy options `_jobmanager.heap.size_` (or 
> `_jobmanager.heap.mb_`) is used in JM standalone bash scripts to pass JVM 
> heap size arg and start JM JVM process.
> BashJavaUtils should be extended to get JVM memory arg list string from Flink 
> configuration. BashJavaUtils can use 
> JobManagerProcessUtils#processSpecFromConfig to obtain JobManagerProcessSpec. 
> JobManagerProcessSpec can be passed to 
> ProcessMemoryUtils#generateJvmParametersStr to get JVM memory arg list string.
> The configuration should be fixed to fallback to 
> JobManagerOptions.JVM_HEAP_MEMORY if a legacy option is set 
> (JobManagerProcessUtils#getConfigurationWithLegacyHeapSizeMappedToNewConfigOption)
>  before passing it to JobManagerProcessUtils#processSpecFromConfig.
> Then the VM memory arg list from BashJavaUtils can be used in JM standalone 
> bash scripts instead the existing bash code which parses legacy heap options: 
> `_jobmanager.heap.size_` (or `_jobmanager.heap.mb_`).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to