Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1032#issuecomment-162518625
Hi @sachingoel0101, I just reviewed quickly. I have some questions and
comments for this pull request.
First, why `FieldStats` covers statistics value for continuous and discrete
values? There is no common value between statistics value for continuous and
that for discrete. How about split them into `ContinuousFieldStats` and
`DiscreteFieldStats`?
Second, many scaladocs are written in javadoc style.
Third, we need to generalize type of the input dataset to `DataSet[T]`
whose generic parameter is `T <: Vector` because `DataSet[Vector]` cannot cover
`DataSet[DenseVector]` and `DataSet[SparseVector]`.
If there is something which I misunderstood, please feel free to leave a
comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
