rkhachatryan commented on a change in pull request #11491:
[FLINK-16513][checkpointing] Unaligned checkpoints: checkpoint metadata
URL: https://github.com/apache/flink/pull/11491#discussion_r397450878
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorFailureTest.java
##########
@@ -116,6 +122,8 @@ public void testFailingCompletedCheckpointStoreAdd()
throws Exception {
verify(operatorSubtaskState.getRawOperatorState().iterator().next()).discardState();
verify(operatorSubtaskState.getManagedKeyedState().iterator().next()).discardState();
verify(operatorSubtaskState.getRawKeyedState().iterator().next()).discardState();
+
verify(operatorSubtaskState.getInputChannelState().iterator().next()).discardState();
+
verify(operatorSubtaskState.getResultSubpartitionState().iterator().next()).discardState();
Review comment:
Agree, but this is an existing test which already uses mockito.
Having some fields mocked and some not would be confusing and changing the
whole test is out of scope of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
